Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[review and merge in aug 2024] remove fal related resources #5368

Merged
merged 20 commits into from
Aug 12, 2024
Merged

[review and merge in aug 2024] remove fal related resources #5368

merged 20 commits into from
Aug 12, 2024

Conversation

kiwamizamurai
Copy link
Contributor

@kiwamizamurai kiwamizamurai commented Apr 26, 2024 •
edited
Loading

Update
We will review and merge this PR around Aug 2024 to give users time to adjust to this adapter sunset. to ease the removal , we're going to:

  • phase 1: add a callout that the dbt fal adapter isn't being maintained/supported anymore. this helps set expectations for users.
  • phase 2: fully merge THIS PR to remove the docs around aug 2024 time.

What are you changing in this pull request and why?

Delete dbt-fal documentation because it has been archived

https://github.com/fal-ai/dbt-fal

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@kiwamizamurai kiwamizamurai requested review from dataders and a team as code owners April 26, 2024 06:29
@welcome Welcome
Copy link

welcome bot commented Apr 26, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024

@kiwamizamurai is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Apr 26, 2024
@github-actions github-actions bot added content Improvements or additions to content developer blog This content fits on the developer blog. size: medium This change will take up to a week to address labels Apr 26, 2024
@kiwamizamurai
Copy link
Contributor Author

@mirnawong1

could you review this pr?

@mirnawong1
Copy link
Contributor

mirnawong1 commented May 7, 2024 •
edited
Loading

hey @kiwamizamurai thanks so much for your proactive pr - really appreciate it ✨! we've decided to approach this sunset in phases since some users are still using dbt-fal and we want to ease the removal a bit:

  • phase 1: add a callout that the dbt fal adapter isn't being maintained/supported anymore. this helps set expectations for users.
  • phase 2: fully remove the docs in a couple of months time using your PR.

so we'll wait a couple of months and then use your pr to completely remove the docs from the docs site. I've also checked with the adapter maintainer on this @chamini2 to confirm too! let me know if you have other ideas/opinions but this pr is really going to help users when we merge it in a couple of months!

@mirnawong1 mirnawong1 changed the title remove fal related resources [review and merge in aug 2024] remove fal related resources May 7, 2024
@mirnawong1 mirnawong1 marked this pull request as draft May 7, 2024 10:36
@mirnawong1
Copy link
Contributor

converting this to draft until aug 2024

@mirnawong1 mirnawong1 mentioned this pull request May 7, 2024
Merged
@mirnawong1
Copy link
Contributor

phase 1 pr here: #5454

dataders added a commit that referenced this pull request May 7, 2024
@dataders
add deprecation callout (#5454)
ae559fd 
this pr adds a callout to the dbt fal adapter docs as its no longer
being maintained actively.

this pr is the first phase inspired by @kiwamizamurai 's first pr.

#5368

this was confirmed and ok'ed by @chamini2 (maintainer)
@kiwamizamurai
Copy link
Contributor Author

@mirnawong1
Thank you very much.
#5454

OK, I wait for the phase 2

@mirnawong1
Copy link
Contributor

confirming if ok to remove from teh site now. will change pr status to 'ready for review' soon once confirmed.

@mirnawong1 mirnawong1 marked this pull request as ready for review August 8, 2024 09:01
@mirnawong1
Copy link
Contributor

hey @kiwamizamurai ! happy thursday and hope you're doing well! i'm trying to resolve the merge conflicts but unfortunately i don't have permission to your forked. any chance you're able to?

@kiwamizamurai
Copy link
Contributor Author

@mirnawong1

ok, i'll do it

@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 12, 2024 7:19am

@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Aug 8, 2024
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: large This change will more than a week to address and might require more than one person labels Aug 8, 2024
kiwamizamurai
kiwamizamurai commented Aug 8, 2024
View reviewed changes
website/vercel.json Outdated Show resolved Hide resolved
kiwamizamurai
kiwamizamurai commented Aug 8, 2024
View reviewed changes
website/vercel.json Outdated Show resolved Hide resolved
@kiwamizamurai
Copy link
Contributor Author

@mirnawong1
please check it

@mirnawong1
Update vercel.json
5e26368 
add redirects
@mirnawong1
Copy link
Contributor

hey @kiwamizamurai , that's awesome and thanks so much for your contribution! I've messaged the maintainers and will get this merged for you!

mirnawong1
mirnawong1 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @kiwamizamurai for opening this up again and really appreciate this great contribution!

@mirnawong1 mirnawong1 enabled auto-merge (squash) August 12, 2024 07:14
@mirnawong1 mirnawong1 merged commit 6575fbf into dbt-labs:current Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@dataders dataders Awaiting requested review from dataders

Assignees
No one assigned
Labels
content Improvements or additions to content developer blog This content fits on the developer blog. new contributor Label for first-time contributors size: medium This change will take up to a week to address trigger-crawl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiwamizamurai @mirnawong1 @runleonarun @matthewshaver